azure: Update Azure SDK and fix breaking changes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
update/azure-sdk
branch
5 times, most recently
from
28d9e7c to
433e066
Compare
phillebaba
commented
Nov 9, 2022
phillebaba
force-pushed
the
update/azure-sdk
branch
8 times, most recently
from
46ee9cb to
7931725
Compare
|
Needed to bump faillint version as panics were occurring with the old version for some reason. |
saswatamcode
approved these changes
Dec 6, 2022
|
Loos like we need to fix a conflict and then we can merge |
phillebaba
force-pushed
the
update/azure-sdk
branch
from
7931725 to
5f4d5fc
Compare
|
@squat done! |
|
(trying to re-trigger tests) |
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
update/azure-sdk
branch
from
5f4d5fc to
46a5942
Compare
|
@squat could we merge this now? |
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Azure Go SDK team has once again introduced breaking changes to the SDK. As far as I can see these are mostly related to user experience and have little to do with performance. This change updates all Azure dependencies and fixes the breaking changes to avoid having to make even larger changes in the future.
Verification
Running tests in my own environment.