Add support for object upload options #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to be able to set the content type on uploaded objects since some providers cannot show a preview if the content type is missing. To facilitate this, I've extended the UploadObject method to accept a variable list of options. The only introduction option is the content type, but it is extensible for other options. Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
bwplotka
reviewed
Feb 27, 2025
| @@ -62,7 +62,7 @@ type Bucket interface { | |||
|
|
|||
| // Upload the contents of the reader as an object into the bucket. | |||
| // Upload should be idempotent. | |||
| Upload(ctx context.Context, name string, r io.Reader) error | |||
| Upload(ctx context.Context, name string, r io.Reader, opts ...ObjectUploadOption) error | |||
There was a problem hiding this comment.
Why not simpler?
Suggested change
| Upload(ctx context.Context, name string, r io.Reader, opts ...ObjectUploadOption) error | |
| Upload(ctx context.Context, name string, r io.Reader, opts ...UploadOption) error |
| ContentType string | ||
| } | ||
|
|
||
| type ObjectUploadOption func(f *UploadObjectParams) |
There was a problem hiding this comment.
I think we can simplify (no need for params to be public struct):
Suggested change
| type ObjectUploadOption func(f *UploadObjectParams) | |
| type UploadOption func(f *uploadOptions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to set the content type on uploaded objects since some providers cannot show a preview if the content type is missing.
To facilitate this, I've extended the UploadObject method to accept a variable list of options. The only introduction option is the content type, but it is extensible for other options.
Changes
Verification