feat: Decouple creating bucket metrics from instrumenting the bucket #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a single process uses multiple object client, we get metrics duplicate registration failures. With this PR, 1. New `BucketMetrics` API return just a `Metrics` that can be created once and used for multiple clients. 2. New `Wrap` API that takes `metrics` and returns instrumented bucket just like `WrapWithMetrics` API. This PR doesn't change any existing API `WrapWithMetrics` Signed-off-by: Kaviraj Kanagaraj <[email protected]>
kavirajk
changed the title
Signed-off-by: Kaviraj Kanagaraj <[email protected]>
Signed-off-by: Kaviraj Kanagaraj <[email protected]>
Signed-off-by: Kaviraj Kanagaraj <[email protected]>
8 tasks
|
@yeya24 thanks. Can you merge it as well? |
|
Done! I was hoping to get an approval from another maintainer but I think the change should be straightforward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently if a single process uses multiple object client, we get metrics duplicate registration failures.
With this PR,
BucketMetricsAPI return just aMetricsthat can be created once and used for multiple clients.WrapAPI that takesmetricsand returns instrumented bucket just likeWrapWithMetricsAPI.This PR doesn't change any existing API
WrapWithMetricsVerification
Not breaking any existing API(s). All existing tests passes