Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCS: Fix logic for falling back to Google defaults #106

Merged
merged 1 commit into from
Feb 28, 2024
Merged

GCS: Fix logic for falling back to Google defaults #106

merged 1 commit into from
Feb 28, 2024

Conversation

saswatamcode
Copy link
Member

@saswatamcode saswatamcode commented Feb 28, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #104

Verification

This was referenced Feb 28, 2024
Merged
Closed
JoaoBraveCoding
JoaoBraveCoding approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saswatamcode saswatamcode merged commit c3ccc5d into thanos-io:main Feb 28, 2024
7 checks passed
@jhalterman
Copy link

jhalterman commented Feb 29, 2024 •
edited
Loading

Unfortunately this didn't resolve the issue for us. When dropping the latest Thanos with this PR into our app, with no other changes, we're getting:

oauth2: cannot fetch token: 400 Bad Request\nResponse: {\"error\":\"invalid_scope\",\"error_description\":\"Invalid OAuth scope or ID token audience provided.\"

This happens when making a GET request against a GCS bucket.

@saswatamcode
Copy link
Member Author

saswatamcode commented Feb 29, 2024 •
edited
Loading

Could you provide more details as to how it was failing before? Was it the same error @jhalterman?

@jhalterman
Copy link

jhalterman commented Feb 29, 2024 •
edited
Loading

Sorry, I meant that this doesn't solve the issue that was introduced by #86 for us. This is an error that only happens after we updated our objstore dependency to include the changes from #86 and this PR.

JoaoBraveCoding added a commit to JoaoBraveCoding/objstore that referenced this pull request Mar 4, 2024
@JoaoBraveCoding
GCS: adds scope to fix bug introduced in thanos-io#86
688d47c 
Issue was reported in thanos-io#106 (comment)
@JoaoBraveCoding JoaoBraveCoding mentioned this pull request Mar 4, 2024
Merged
2 tasks
JoaoBraveCoding added a commit to JoaoBraveCoding/objstore that referenced this pull request Mar 4, 2024
@JoaoBraveCoding
GCS: adds scope to fix bug introduced in thanos-io#86
2152959 
Issue was reported in thanos-io#106 (comment)

Signed-off-by: Joao Marcal <[email protected]>
saswatamcode pushed a commit that referenced this pull request Mar 9, 2024
@JoaoBraveCoding
GCS: adds scope to fix bug introduced in HTTPConfig support (#109)
e8336a5 
GCS: adds scope to fix bug introduced in #86
Issue was reported in #106 (comment)

Signed-off-by: Joao Marcal <[email protected]>
@yeya24 yeya24 mentioned this pull request Mar 25, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable GCS to work with GKE workload identity/GOOGLE_APPLICATION_CREDENTIALS
3 participants
@saswatamcode @jhalterman @JoaoBraveCoding