Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TH2-5179] Implemented value formatter related to JDBC database type #24

Merged
merged 17 commits into from
Apr 8, 2024

Conversation

Nikita-Smirnov-Exactpro
Copy link
Member

No description provided.

Copy link
Member

@OptimumCode OptimumCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the tests. Some of them are failed

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro marked this pull request as ready for review April 3, 2024 17:33
Copy link
Member

@OptimumCode OptimumCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that you have failed tests for oracle extension.
If those tests are flake tests we should fix them

@Nikita-Smirnov-Exactpro
Copy link
Member Author

Please note that you have failed tests for oracle extension. If those tests are flake tests we should fix them

I would like to merge all pull requests related to the TH2-5179 issue as separate commits and after that build 0.9.1 dev release

@OptimumCode
Copy link
Member

Please note that you have failed tests for oracle extension. If those tests are flake tests we should fix them

I would like to merge all pull requests related to the TH2-5179 issue as separate commits and after that build 0.9.1 dev release

Okay

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro changed the base branch from TH2-5179 to master April 8, 2024 07:40
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro merged commit ebeb69e into master Apr 8, 2024
1 check passed
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro deleted the TH2-5179-value-formatter branch April 8, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants