Prevents the most common case of fire settling with an excited group #56317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically when a group with a breakdown timer one tick away from settling merges with a group with hotspots in it, and the one with a high breakdown timer is larger, the group would settle without respecting the timer of the hotspot group, causing fwoosh levels of flame. There's two other ways to achieve this, if you had one group of tiles that are close to the same gasmix as another group, and they became inactive, we'd have the same issue. I've solved this by moving the hotspot subprocess to after active turfs and before excited groups, just for safety ya feel me? It's still in theory possible, but much much harder. The hard solution to this would be to integrate heat with how we reset excited group timers, and split excited groups into smaller portions, but I'm not sure I like that idea. I need to mull it over.
tgstation-server
added
the
Fix
|
I need to document excited timers more thoroughly, but that will come later |
|
On the one hand, bug. On the other hand, awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Basically when a group with a breakdown timer one tick away from settling merges with a group with hotspots in
it, and the one with a high breakdown timer is larger, the group would settle without respecting the timer of
the hotspot group, causing fwoosh levels of flame.
There's two other ways to achieve this, if you had one group of tiles that are close to the same gasmix as another
group, except really hot, and they became inactive, we'd have the same issue. I've solved this by moving the hotspot subprocess to
after active turfs and before excited groups, just for safety ya feel me?
It's still in theory possible, but much much harder. The hard solution to this would be to integrate heat with
how we reset excited group timers, and split excited groups into smaller portions, but I'm not sure I like that idea.
I need to mull it over.
Oh and I did some cleanup of SSair.
Why It's Good For The Game
Almost totally prevents this
Changelog
🆑
fix: Fixes an edgecase where groups of gas could settle while on fire
/:cl: