Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Response format (Json mode) Provided by Mistral #3

Merged
merged 2 commits into from
May 18, 2024

Conversation

Passant-Ihab
Copy link

No description provided.

@Skarzag
Copy link

Skarzag commented May 5, 2024

Can't wait for this merge to be done ! 😄

@tghamm
Copy link
Owner

tghamm commented May 5, 2024

@Skarzag @Passant-Ihab sorry for the delay, I'll get this out tomorrow! 🙂

@Skarzag
Copy link

Skarzag commented May 16, 2024

Hi @tghamm , no problem, will you get any time soon to do this ?

@tghamm
Copy link
Owner

tghamm commented May 17, 2024

@Skarzag my apologies, yes, I'll get it done this weekend. Thanks for your patience, life has gotten in the way the last couple of weeks unexpectedly.

adds unit tests for json mode
@tghamm tghamm merged commit f6c8e3e into tghamm:main May 18, 2024
1 check passed
@tghamm
Copy link
Owner

tghamm commented May 18, 2024

@Passant-Ihab thanks for the contribution and apologies for the delay, this has been incorporated and released.

@Skarzag
Copy link

Skarzag commented May 19, 2024

@tghamm , no worries ! Do what you can do whenever you can ! Thanks to both of you anyway ;)

@Passant-Ihab
Copy link
Author

@tghamm no worries! Thank you for processing it, really appreciated that will really help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants