Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal in now required? #775

Closed
TheSuperiorStanislav opened this issue Jul 26, 2022 · 5 comments
Closed

gdal in now required? #775

TheSuperiorStanislav opened this issue Jul 26, 2022 · 5 comments
Labels
bug Something isn't working fix confirmation pending issue has been fixed and confirmation from issue reporter is pending

Comments

@TheSuperiorStanislav
Copy link

Describe the bug
Is gdal now required for package usage? Because currently, we have GitHub actions that are failing because gdal is not installed by default.

image
image

To Reproduce
Try to run on the system(container) without gdal installed

Expected behavior
gdal is required only if rest_framework_gis is installed
@Bidaya0
Copy link

Bidaya0 commented Jul 26, 2022

Can you help me review this pr? I had the same problem.
I don't really understand how the plugin mode of this project works, so just made a simple change to fix it.

#777

@colinschwegmann
Copy link

colinschwegmann commented Jul 26, 2022 •
edited
Loading

Pretty big breaking change unless there was a warning? My own build is failing too due to this new requirement.

I'd prefer to not need GDAL installed if I can avoid it. Especially as it is currently unrelated to any of the DRF things I do right now.

Going to set required version to drf-spectacular==0.22.1 until this is resolved.

@tfranzel
Copy link
Owner

looking into it right now. no, GDAL is not a new requirement! it is supposed to be optional in case it is actually used. This goes for all the contrib packages we support.

I tested this in a project without GIS and it did not occur. Trying to find out why atm. Will merge #777 asap and do a hotfix release today.

@tfranzel tfranzel added the bug Something isn't working label Jul 26, 2022
@tfranzel
Copy link
Owner

Ok so thanks to @Bidaya0 for providing the hotfix. I just released 0.23.1. Sorry about the inconvenience.

Poetry fooled me good into believing I was testing the new version.

@tfranzel tfranzel added the fix confirmation pending issue has been fixed and confirmation from issue reporter is pending label Jul 26, 2022
@TheSuperiorStanislav
Copy link
Author

With 0.23.1 it works as expected. Thank you @Bidaya0 and @tfranzel

tfranzel added a commit that referenced this issue Feb 25, 2023
@tfranzel
mitigate runtests.py fail when GDAL library is not installed #945 #821
4fde93e 
 #775 #777

will coventiently make ``./runtests.py`` brush over system library
requirements to help contributors run the test suite locally without
installing extra stuff.

full tox run will require it though.
@tfranzel tfranzel mentioned this issue Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fix confirmation pending issue has been fixed and confirmation from issue reporter is pending
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tfranzel @TheSuperiorStanislav @Bidaya0 @colinschwegmann