Simple JWT integration goes wrong.

[dem214]

Describe the bug
Generated schema shows wrong response schema of rest_fremework_simplejwt.views.TokenObtainPairView()

To Reproduce
Add this to urls of new django project:

from rest_framework_simplejwt.views import TokenObtainPairView

urlpatterns += [path("api/token/", TokenObtainPairView.as_view(), name='token_obtain_pair'),]

Check the schema.

Expected behavior
api/token/ view must response with schema like {"access":string,"refresh":string}

Versions
django==3.0.10
djangorestframework==3.12.1
djangorestframework-simplejwt==4.4.0
drf-spectacular==0.11.1

See also
Same problem can be with from rest_framework_simplejwt.views.TokenRefreshView

[tfranzel]

Hi @dem214, djangorestframework-simplejwt has a weird way of constructing those serializers. this should solve it.

[marcinjosinski]

Hello,
@tfranzel this fix resolves all problems except the token/refresh view.

Something like that fixes schema for token/refresh view too.

class SimpleJWTTokenRefreshView(OpenApiViewExtension):
    target_class = 'rest_framework_simplejwt.views.TokenRefreshView'

    def view_replacement(self):
        if getattr(settings, 'SIMPLE_JWT', {}).get('ROTATE_REFRESH_TOKENS', False):
            class TokenRefreshResponseSerializer(serializers.Serializer):
                access = serializers.CharField()
                refresh = serializers.CharField()
        else:
            class TokenRefreshResponseSerializer(serializers.Serializer):
                access = serializers.CharField()

        class Fixed(self.target_class):
            @extend_schema(responses=TokenRefreshResponseSerializer)
            def post(self, request, *args, **kwargs):
                pass  # pragma: no cover

        return Fixed

@tfranzel By the way, thanks for maintaining such a great project!

[dem214]

Nicely done

[tfranzel]

hey @marcinjosinski, i missed that one too. slightly modified your proposal to target TokenRefreshSerializer instead of the view.

            class TokenRefreshResponseSerializer(serializers.Serializer):
                access = serializers.CharField()

i think your proposal has a slight bug. as far as i understand, for ROTATE_REFRESH_TOKENS=False the serializer has refresh (request only) and access (response only). can you confirm this is now correct?

this also fixes dj_rest_auth as it optionally uses simple JWT. yeah!

[marcinjosinski]

My proposal gives the same results because I override responses here only, but targeting the Serializer is a more elegant solution.

I've just checked it and everything looks good. Thanks!