Skip to content

Commit

Permalink
🐛 Fix theme_guide(key.width, key.height, key.size) (#53)
Browse files Browse the repository at this point in the history
* mirror filename

* propagate key sizes

* add test

* add news bullet
  • Loading branch information
teunbrand authored Feb 15, 2025
1 parent 073ae43 commit 04a1bc7
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 0 deletions.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# legendry (development version)

* Fixed bug hindering `position = "inside"` placement (#42)
* Fixed bug in `theme_guide(key.size, key.height, key.width)` (#41)

# legendry 0.2.0

Expand Down
3 changes: 3 additions & 0 deletions R/themes.R
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ theme_guide <- function(
legend.key.spacing = key.spacing,
legend.key.spacing.x = key.spacing.x,
legend.key.spacing.y = key.spacing.y,
legend.key.size = key.size,
legend.key.width = key.width,
legend.key.height = key.height,
legendry.legend.key.margin = key.margin,

legend.frame = frame,
Expand Down
23 changes: 23 additions & 0 deletions tests/testthat/test-themes.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@

test_that("theme elements can be registered", {

expect_in("legendry.bracket", names(get_element_tree()))

ggplot2::reset_theme_settings()

expect_false("legendry.bracket" %in% names(get_element_tree()))

register_legendry_elements()

expect_in("legendry.bracket", names(get_element_tree()))

})

test_that("all arguments of theme_guide are used", {

fmls <- fn_fmls_names(theme_guide)
args <- set_names(seq_along(fmls), fmls)
theme <- inject(theme_guide(!!!args))
expect_setequal(unlist(theme), seq_along(fmls))

})

0 comments on commit 04a1bc7

Please sign in to comment.