Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to JDK11 #2705

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Upgrade to JDK11 #2705

merged 1 commit into from
Jan 7, 2022

Conversation

krmahadevan
Copy link
Member

  • Also upgraded all the dependencies to the latest
  • Fixed the matrix as well to toggle between 11/16/17

Fixes #2637

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

@krmahadevan krmahadevan requested a review from juherr January 7, 2022 06:17
juherr
juherr requested changes Jan 7, 2022
View reviewed changes
Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented version are just here to show you all available new versions. When you upgrade you are supposed to remove old versions.

settings.gradle.kts Outdated Show resolved Hide resolved
versions.properties Outdated Show resolved Hide resolved
@krmahadevan
Copy link
Member Author

@juherr - Can you please take a quick look once again ? I have fixed the review comments.

juherr
juherr requested changes Jan 7, 2022
View reviewed changes
.github/workflows/matrix.js Outdated Show resolved Hide resolved
versions.properties Show resolved Hide resolved
@krmahadevan
Copy link
Member Author

@juherr - I have fixed both the review comments. Please check

@krmahadevan krmahadevan requested a review from juherr January 7, 2022 10:52
juherr
juherr approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the last issue and merge 👍

.github/workflows/matrix.js Outdated Show resolved Hide resolved
@krmahadevan
Upgrade to JDK11
855ea07 
Closes testng-team#2637

* Also upgraded all the dependencies to the latest
* Fixed the matrix as well to toggle between 11/16/17
@krmahadevan krmahadevan merged commit 51efe0e into testng-team:master Jan 7, 2022
@krmahadevan krmahadevan deleted the bump_jdk branch January 7, 2022 13:34
@smcvb smcvb mentioned this pull request May 23, 2022
Closed
@abutch3r abutch3r mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juherr juherr juherr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Java 11
2 participants
@krmahadevan @juherr