Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typings): add ts definitions #7

Merged
merged 2 commits into from
Mar 20, 2018

Conversation

Miklet
Copy link
Contributor

@Miklet Miklet commented Mar 20, 2018

What: Added TypeScript definitions.

Why: To let TypeScript's users better use library 😃.

How: Added definition file.

Checklist:

  • Documentation "N/A"
  • Tests "N/A"
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Mar 20, 2018

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           6      6           
=====================================
  Hits            6      6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e2a02a...3d818b6. Read the comment docs.

@Miklet
Copy link
Contributor Author

Miklet commented Mar 20, 2018

Ohh I see there was a change on master. I will update definition file and push again.

@edit

Updated 😄

@Miklet Miklet force-pushed the feature/ts-typings branch from 8218ee0 to 3d818b6 Compare March 20, 2018 18:28
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I won't maintain these myself, but I'm happy to accept pull requests for it!

@kentcdodds kentcdodds merged commit 213055a into testing-library:master Mar 20, 2018
@Miklet
Copy link
Contributor Author

Miklet commented Mar 20, 2018

If there won't be a person to fix or update typings you can @ me, I will try to help :)

@Miklet Miklet deleted the feature/ts-typings branch March 20, 2018 18:47
kentcdodds pushed a commit that referenced this pull request Mar 20, 2018
* feat(typings): add ts definitions

* chore(contributors): add myself
kentcdodds pushed a commit that referenced this pull request Mar 20, 2018
* feat(typings): add ts definitions

* chore(contributors): add myself
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants