fix: use exact match for data-testid #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add tests to exercise error paths for EDIT: done |
alexkrolick
commented
May 4, 2018
| export {matches} | ||
| function matchesExact(textToMatch, node, matcher) { | ||
| if (typeof textToMatch !== 'string') { | ||
| return false |
There was a problem hiding this comment.
This is the only line not exercised by public api tests because the exact match is already pre-filtered with querySelectorAll in queryAllByAttribute. Added unit tests for the matchers instead to document match behavior.
kentcdodds
approved these changes
May 4, 2018
kentcdodds
approved these changes
May 4, 2018
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
alexkrolick
pushed a commit
to alexkrolick/dom-testing-library
that referenced
this pull request
Sep 13, 2018
* docs(contributors): add sompylasar * docs(contributors): fix @lgandecki missing docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fixes #8]
What:
Why:
How:
Checklist: