Add bitswap test suite #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2020
dirkmc
force-pushed
the
feat/bitswap-test-suite
branch
from
a5ce59f to
f223a49
Compare
|
@dirkmc we can probably rebase and land this, right? |
|
Yes, it's just been waiting for review - I will rebase and ping you |
dirkmc
force-pushed
the
feat/bitswap-test-suite
branch
from
e3e48dd to
c1f754f
Compare
|
@Stebalien I rebased so this is now mergeable - I have another branch that depends on this one that also cleans up some of the code, so if there's nothing major I'd suggest we merge and then refactor |
Stebalien
force-pushed
the
feat/bitswap-test-suite
branch
from
da297a1 to
f0668f2
Compare
|
Yeah, this PR just touches the test plan so I'm not concerned about potential issues. |
Stebalien
approved these changes
Feb 13, 2020
Stebalien
force-pushed
the
feat/bitswap-test-suite
branch
from
ccde3c9 to
7e3c773
Compare
|
I fixed the lints to get CI passing. |
Stebalien
force-pushed
the
feat/bitswap-test-suite
branch
from
7e3c773 to
519a144
Compare
Stebalien
force-pushed
the
feat/bitswap-test-suite
branch
from
519a144 to
b1f6c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains test suites that
Results: Path to landing Bitswap PoC ipfs/kubo#6782
Results: https://github.com/ipfs/testground/issues/436