Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to define a custom ImagePullPolicy via configuration #7520

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Allow to define a custom ImagePullPolicy via configuration #7520

merged 9 commits into from
Sep 27, 2023

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Sep 8, 2023 •
edited
Loading

Fixes #7405

@eddumelendez eddumelendez marked this pull request as ready for review September 10, 2023 22:16
@eddumelendez eddumelendez requested a review from a team as a code owner September 10, 2023 22:16
@eddumelendez eddumelendez added this to the next milestone Sep 10, 2023
kiview
kiview requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a better test before merging (but open to discuss it), see comments.

core/src/main/java/org/testcontainers/images/PullPolicy.java Outdated Show resolved Hide resolved
core/src/main/java/org/testcontainers/images/PullPolicy.java Outdated Show resolved Hide resolved
core/src/test/java/org/testcontainers/images/OverrideImagePullPolicyTest.java Outdated Show resolved Hide resolved
@eddumelendez eddumelendez requested a review from kiview September 14, 2023 19:40
kiview
kiview previously approved these changes Sep 27, 2023
View reviewed changes
bsideup
bsideup previously approved these changes Sep 27, 2023
View reviewed changes
@eddumelendez eddumelendez dismissed stale reviews from bsideup and kiview via 9021643 September 27, 2023 15:55
@eddumelendez eddumelendez merged commit 8b6776c into main Sep 27, 2023
@eddumelendez eddumelendez deleted the imagepullpolicy-config branch September 27, 2023 17:06
@OLibutzki
Copy link

Thanks for providing this helpful configuration!

@eddumelendez ,
does the configuration affect the pull policy for database containers launched via JDBC URL scheme, too?

@eddumelendez
Copy link
Member Author

Yes, it should. Testcontainers JDBC URL uses the Database container implementation under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview left review comments

@bsideup bsideup bsideup left review comments

Assignees
No one assigned
Labels
type/docs type/enhancement
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add global configuration for pull policy
4 participants
@eddumelendez @OLibutzki @bsideup @kiview