Modify JDBC driver connection behaviour to fail early if the delegate…

… JDBC Driver cannot be instantiated. Connection attempts remain inside a retry loop. Refs #230
testcontainers · Jan 22, 2017 · d8d6df8 · d8d6df8
1 parent deab822
commit d8d6df8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java b/modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java
@@ -117,8 +117,10 @@ public Connection createConnection(String queryString) throws SQLException {
         info.put("password", this.getPassword());
         final String url = this.getJdbcUrl() + queryString;
 
+        final Driver jdbcDriverInstance = getJdbcDriverInstance();
+
         try {
-            return Unreliables.retryUntilSuccess(120, TimeUnit.SECONDS, () -> getJdbcDriverInstance().connect(url, info));
+            return Unreliables.retryUntilSuccess(120, TimeUnit.SECONDS, () -> jdbcDriverInstance.connect(url, info));
         } catch (Exception e) {
             throw new SQLException("Could not create new connection", e);
         }