Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Algin module configurations #1357

Merged
merged 1 commit into from
Feb 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lts/*
12 changes: 6 additions & 6 deletions src/Testcontainers.DynamoDb/DynamoDbBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ public DynamoDbBuilder()
/// <summary>
/// Initializes a new instance of the <see cref="DynamoDbBuilder" /> class.
/// </summary>
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
private DynamoDbBuilder(DynamoDbConfiguration dockerResourceConfiguration)
: base(dockerResourceConfiguration)
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
private DynamoDbBuilder(DynamoDbConfiguration resourceConfiguration)
: base(resourceConfiguration)
{
DockerResourceConfiguration = dockerResourceConfiguration;
DockerResourceConfiguration = resourceConfiguration;
}

/// <inheritdoc />
Expand All @@ -48,13 +48,13 @@ protected override DynamoDbBuilder Init()
}

/// <inheritdoc />
protected override DynamoDbBuilder Clone(IContainerConfiguration resourceConfiguration)
protected override DynamoDbBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
{
return Merge(DockerResourceConfiguration, new DynamoDbConfiguration(resourceConfiguration));
}

/// <inheritdoc />
protected override DynamoDbBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
protected override DynamoDbBuilder Clone(IContainerConfiguration resourceConfiguration)
{
return Merge(DockerResourceConfiguration, new DynamoDbConfiguration(resourceConfiguration));
}
Expand Down
12 changes: 6 additions & 6 deletions src/Testcontainers.EventStoreDb/EventStoreDbBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ public EventStoreDbBuilder()
/// <summary>
/// Initializes a new instance of the <see cref="EventStoreDbBuilder" /> class.
/// </summary>
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
private EventStoreDbBuilder(EventStoreDbConfiguration dockerResourceConfiguration)
: base(dockerResourceConfiguration)
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
private EventStoreDbBuilder(EventStoreDbConfiguration resourceConfiguration)
: base(resourceConfiguration)
{
DockerResourceConfiguration = dockerResourceConfiguration;
DockerResourceConfiguration = resourceConfiguration;
}

/// <inheritdoc />
Expand All @@ -50,13 +50,13 @@ protected override EventStoreDbBuilder Init()
}

/// <inheritdoc />
protected override EventStoreDbBuilder Clone(IContainerConfiguration resourceConfiguration)
protected override EventStoreDbBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
{
return Merge(DockerResourceConfiguration, new EventStoreDbConfiguration(resourceConfiguration));
}

/// <inheritdoc />
protected override EventStoreDbBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
protected override EventStoreDbBuilder Clone(IContainerConfiguration resourceConfiguration)
{
return Merge(DockerResourceConfiguration, new EventStoreDbConfiguration(resourceConfiguration));
}
Expand Down
8 changes: 4 additions & 4 deletions src/Testcontainers.FakeGcsServer/FakeGcsServerBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ public FakeGcsServerBuilder()
/// <summary>
/// Initializes a new instance of the <see cref="FakeGcsServerBuilder" /> class.
/// </summary>
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
private FakeGcsServerBuilder(FakeGcsServerConfiguration dockerResourceConfiguration)
: base(dockerResourceConfiguration)
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
private FakeGcsServerBuilder(FakeGcsServerConfiguration resourceConfiguration)
: base(resourceConfiguration)
{
DockerResourceConfiguration = dockerResourceConfiguration;
DockerResourceConfiguration = resourceConfiguration;
}

/// <inheritdoc />
Expand Down
12 changes: 6 additions & 6 deletions src/Testcontainers.LocalStack/LocalStackBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ public LocalStackBuilder()
/// <summary>
/// Initializes a new instance of the <see cref="LocalStackBuilder" /> class.
/// </summary>
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
private LocalStackBuilder(LocalStackConfiguration dockerResourceConfiguration)
: base(dockerResourceConfiguration)
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
private LocalStackBuilder(LocalStackConfiguration resourceConfiguration)
: base(resourceConfiguration)
{
DockerResourceConfiguration = dockerResourceConfiguration;
DockerResourceConfiguration = resourceConfiguration;
}

/// <inheritdoc />
Expand All @@ -48,13 +48,13 @@ protected override LocalStackBuilder Init()
}

/// <inheritdoc />
protected override LocalStackBuilder Clone(IContainerConfiguration resourceConfiguration)
protected override LocalStackBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
{
return Merge(DockerResourceConfiguration, new LocalStackConfiguration(resourceConfiguration));
}

/// <inheritdoc />
protected override LocalStackBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
protected override LocalStackBuilder Clone(IContainerConfiguration resourceConfiguration)
{
return Merge(DockerResourceConfiguration, new LocalStackConfiguration(resourceConfiguration));
}
Expand Down
12 changes: 6 additions & 6 deletions src/Testcontainers.Minio/MinioBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ public MinioBuilder()
/// <summary>
/// Initializes a new instance of the <see cref="MinioBuilder" /> class.
/// </summary>
/// <param name="dockerResourceConfiguration">The Docker resource configuration.</param>
private MinioBuilder(MinioConfiguration dockerResourceConfiguration)
: base(dockerResourceConfiguration)
/// <param name="resourceConfiguration">The Docker resource configuration.</param>
private MinioBuilder(MinioConfiguration resourceConfiguration)
: base(resourceConfiguration)
{
DockerResourceConfiguration = dockerResourceConfiguration;
DockerResourceConfiguration = resourceConfiguration;
}

/// <inheritdoc />
Expand Down Expand Up @@ -91,13 +91,13 @@ protected override void Validate()
}

/// <inheritdoc />
protected override MinioBuilder Clone(IContainerConfiguration resourceConfiguration)
protected override MinioBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
{
return Merge(DockerResourceConfiguration, new MinioConfiguration(resourceConfiguration));
}

/// <inheritdoc />
protected override MinioBuilder Clone(IResourceConfiguration<CreateContainerParameters> resourceConfiguration)
protected override MinioBuilder Clone(IContainerConfiguration resourceConfiguration)
{
return Merge(DockerResourceConfiguration, new MinioConfiguration(resourceConfiguration));
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Testcontainers.Keycloak.Tests/KeycloakContainerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ public async Task GetOpenIdEndpointReturnsHttpStatusCodeOk()
httpClient.BaseAddress = new Uri(_keycloakContainer.GetBaseAddress());

// When
using var response = await httpClient.GetAsync("/realms/master/.well-known/openid-configuration")
using var httpResponse = await httpClient.GetAsync("/realms/master/.well-known/openid-configuration")
.ConfigureAwait(true);

// Then
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
Assert.Equal(HttpStatusCode.OK, httpResponse.StatusCode);
}

[Fact]
Expand Down
10 changes: 5 additions & 5 deletions tests/Testcontainers.Nats.Tests/NatsContainerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@ public Task DisposeAsync()
public async Task HealthcheckReturnsHttpStatusCodeOk()
{
// Given
using var client = new HttpClient();
client.BaseAddress = new Uri(_natsContainer.GetManagementEndpoint());
using var httpClient = new HttpClient();
httpClient.BaseAddress = new Uri(_natsContainer.GetManagementEndpoint());

// When
using var response = await client.GetAsync("/healthz")
using var httpResponse = await httpClient.GetAsync("/healthz")
.ConfigureAwait(true);

var jsonStatusString = await response.Content.ReadAsStringAsync()
var jsonStatusString = await httpResponse.Content.ReadAsStringAsync()
.ConfigureAwait(true);

// Then
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
Assert.Equal(HttpStatusCode.OK, httpResponse.StatusCode);
Assert.Equal("{\"status\":\"ok\"}", jsonStatusString);
}

Expand Down
12 changes: 6 additions & 6 deletions tests/Testcontainers.Pulsar.Tests/PulsarContainerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -84,20 +84,20 @@ public PulsarAuthConfiguration()
{
}
}

[UsedImplicitly]
public sealed class PulsarDefaultConfigurationLts4 : PulsarContainerTest
public sealed class PulsarV4Configuration : PulsarContainerTest
{
public PulsarDefaultConfigurationLts4()
public PulsarV4Configuration()
: base(new PulsarBuilder().WithImage("apachepulsar/pulsar:4.0.2").Build(), false)
{
}
}

[UsedImplicitly]
public sealed class PulsarAuthConfigurationLts4 : PulsarContainerTest
public sealed class PulsarV4AuthConfiguration : PulsarContainerTest
{
public PulsarAuthConfigurationLts4()
public PulsarV4AuthConfiguration()
: base(new PulsarBuilder().WithImage("apachepulsar/pulsar:4.0.2").WithAuthentication().Build(), true)
{
}
Expand Down