feat: Align IImage properties with Docker DSL
#1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HofmeisterAn
added
enhancement
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
changed the title
IImage properties with Docker DSL
Kielek
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR updates the
IImageandDockerImageimplementations. It improves parsing and resolving the reference format, using parts of the official Go implementation. The table below shows the changes:The
RegistryandDigestproperties have been added to the interface. TheNameproperty is marked obsolete and will be removed in the next minor version. TheRepositoryproperty now resolves the correct value from the reference format according to the Docker DSL.I’ve marked all obsolete parts and provided guidance on how to transition to the new interface. I tried to make the transition as smooth as possible, but relying on the
Repositoryproperty might cause issues since it now resolves a different value than before.Why is it important?
These changes align with other Testcontainers language implementations and address inconsistent APIs and incorrect DSL.
Related issues
IImageproperties (align with DSL) #740IImageproperties to align with DSL #962IImage,DockerImageand in theWithImage(string)implementation #1249