Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subnet_id option for use with VPCs #7

Merged
merged 2 commits into from
May 23, 2013

Conversation

dissonanz
Copy link
Contributor

This provides the ability to create instances in a specified subnet.

@fnichol
Copy link
Contributor

fnichol commented May 23, 2013

Looks good, I could use this as well 😄

Have you, by chance, signed a Contributor License Agreement (CLA) for an Opscode project? If not, would you be willing to? Thank you!

Given the size of this commit I bet we could get a 0.5.1 release out tomorrow.

@dissonanz
Copy link
Contributor Author

I haven't signed a CLA yet, but I'd be happy to.

Updated the README as well.

@dissonanz
Copy link
Contributor Author

CLA signed. ^_^

@fnichol
Copy link
Contributor

fnichol commented May 23, 2013

Looks great, thanks!

fnichol added a commit that referenced this pull request May 23, 2013
Adding subnet_id option for use with VPCs
@fnichol fnichol merged commit 54fb187 into test-kitchen:master May 23, 2013
@fnichol
Copy link
Contributor

fnichol commented May 23, 2013

p.s. I like your avatar, some kind of Gibson ES?

@dissonanz dissonanz deleted the add-subnet-id branch May 23, 2013 21:17
@dissonanz
Copy link
Contributor Author

Thx! It's a Gretsch White Falcon.

@fnichol
Copy link
Contributor

fnichol commented May 23, 2013

Cool, I'm a drummer so I've gotta love Gretsch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants