Add support for IAM credentials #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #55. This change will add support for using IAM temporary credentials when creating EC2 instances. Currently the credentials will have to be set in the environment, while an EC2 instance that's set up with an IAM profile can fetch its temporary credentials from the metadata server.
|
👍 Was just looking into enabling this. Glad someone already fixed the problem. |
Igorshp
added a commit
to Igorshp/kitchen-ec2
that referenced
this pull request
Mar 10, 2015
tweak for PR by daanemanz test-kitchen#68 he has since deleted his fork, so I can't submit a PR to him.
|
def iam_creds
@iam_creds ||= begin
fetch_credentials(use_iam_profile: true)
rescue # TODO what exception does this raise on failure?
debug("fetch_credentials failed with exception #{e.message}:#{e.backtrace.join("\n")}")
{}
end
endI also don't like rescuing all possible exceptions. That could be catching a |
Igorshp
added a commit
to Igorshp/kitchen-ec2
that referenced
this pull request
Mar 30, 2015
tweak for PR by daanemanz test-kitchen#68 he has since deleted his fork, so I can't submit a PR to him.
|
Closing this as it was merged in #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #55.
This change will add support for using IAM temporary credentials when creating EC2 instances. Currently the credentials will have to be set in the environment, while an EC2 instance that's set up with an IAM profile can fetch its temporary credentials from the metadata server.