Least Populated Subnet #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdwyertech
force-pushed
the
least-populated-subnet
branch
6 times, most recently
from
2c480e3 to
951f2aa
Compare
Signed-off-by: Brian Dwyer <[email protected]>
bdwyertech
force-pushed
the
least-populated-subnet
branch
from
951f2aa to
6d646b3
Compare
|
The driver also uses similar logic over here to create a security group if one is not supplied: kitchen-ec2/lib/kitchen/driver/ec2.rb Line 792 in 6d646b3 I could not for the life of me figure out how to mock the following in RSpec: subnet = subnets.sort_by { |s| s[:available_ip_address_count] }.last.vpc_id |
|
Nice. Thanks for putting this together. Definitely would come in handy. |
|
Nice little addition there. Thanks @bdwyertech |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select the least-populated subnet if we have multiple matches -- previously we just took the first match.
VPC may span multiple regions -- subnets are region specific. This lets you pick the least populated VPC.
This should help to distribute the test-kitchen load more evenly across multi-az VPC's while maintaining full backward compatibility.
We've noticed intermittent problems internally with our cookbook generator where folks do not change the default (e.g. org_*_dmz => always resolves to org_us-east-1a-dmz). Kitchens sometimes fail either because of spot instance unavailability, ip starvation, etc.
@sumitag @chefbob @danielcbright