Fix dynamic key creation #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, now I'm trying to remember why I did that. |
|
Semi-related: #399 |
|
That's the exact error I was seeing @cheeseplus ... Idk why the tests see this as not creating the file... File.open is just File.new which accepts a block. Guess I'll dick around with this on my Mac next week. |
Signed-off-by: Brian Dwyer <[email protected]>
|
@coderanger maybe because Ruby was weird at the time regarding file permissions and |
coderanger
approved these changes
Jun 5, 2018
|
I just ran into an issue with this, this fixed it. Can we get this released in a new gem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was seeing a weird issue where Ruby was trying to write to the file before it had actually been created on the file system.... Lost the error output, but it was something along the lines of
File not open for writingMoving this all into one code block has resolved the issue.