Add expiration to spot requests #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wondering what needs to happen on my end to get some discussion on this PR? |
|
We're actually trying to get a release of |
|
👍 |
|
Awesome. Just let me know if anything is needed from me on this, otherwise I'll leave you alone :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a
kitchen convergetimes out then the spot request does not get cleaned up. This means an operator has to manually remove the spot requests, leaving an opening for extra costs that are unnecessary and difficult to track down.It seems to me that we'd want the spot request to expire if it hasn't been fulfilled within the timeframe of
config[:retryable_tries] * config[:retryable_sleep]seconds, so it would make sense to set an expiry on the request as such.