Adding support for tenancy parameter in placement config. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and dedicated values accepted
tyler-ball
changed the title
|
Hi @tyler-ball do you need anything else from my side to improve this PR in order to be merged? Kind regards |
|
Could you please help me to merge this PR? Regards |
|
Hi, can we have this merged? |
|
👍 |
| @@ -79,6 +79,7 @@ class Ec2 < Kitchen::Driver::Base # rubocop:disable Metrics/ClassLength | |||
| default_config :interface, nil | |||
| default_config :http_proxy, ENV["HTTPS_PROXY"] || ENV["HTTP_PROXY"] | |||
| default_config :retry_limit, 3 | |||
| default_config :tenancy, "dedicated" | |||
There was a problem hiding this comment.
Not sure if this is the real default value when tenancy is not specified. I guess that by default should be "default". Guess not everybody wants to use dedicated instances.
added 10 commits
August 6, 2016 09:17
Since two weeks ago, faraday-http-cache 2.0.0 was released but it does not support ruby 2.0.0 anymore (see https://github.com/plataformatec/faraday-http-cache/blob/master/CHANGELOG.md). Using latest 1.3 version.
|
Hi, I just merged from master. Could we have this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only "default" and "dedicated" values are accepted. If you think is worthy to have also "host" value (http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/dedicated-instance.html#dedicated-howitworks) but being honest I've never seen that value in an instance config. This parameter works in pair with availability zone to define the placement attribute.