Adding block_device_mapping iops parameter, fixes #157 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… volume_type of io1
| @@ -280,7 +285,8 @@ storage config keys are present. | |||
|
|
|||
| The keys `ebs_volume_type`, `ebs_virtual_name` and `ebs_snapshot_id` are optional. See | |||
| [Amazon EBS Volume Types](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSVolumeTypes.html) to find out more about | |||
| volume types. `ebs_volume_type` defaults to `standard` but can also be `gp2` or `io1`. | |||
| volume types. `ebs_volume_type` defaults to `standard` but can also be `gp2` or `io1`. If you specify `io1` you must | |||
| also specify `ebs_iops`. | |||
There was a problem hiding this comment.
What happens if a user specifies io1 without specifying ebs_iops?
There was a problem hiding this comment.
They get a 'nice' error from AWS that is shown in the bug report (#157)
|
👍 |
tyler-ball
added a commit
that referenced
this pull request
Jun 24, 2015
Adding block_device_mapping iops parameter, fixes #157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary when specifying volume_type of io1. Fixes #157
\cc @fnichol @metadave @randomcamel