parser,ddl: Support ENGINE_ATTRIBUTE option for future use (pingcap#5…

…9201)

close pingcap#59200

errors.toml

@@ -1341,6 +1341,11 @@ error = '''
 Check constraint '%s' uses column '%s', hence column cannot be dropped or renamed.
 '''
 
+["ddl:3981"]
+error = '''
+Storage engine does not support ENGINE_ATTRIBUTE.
+'''
+
 ["ddl:4135"]
 error = '''
 Sequence '%-.64s.%-.64s' has run out
@@ -1586,6 +1591,16 @@ error = '''
 Auto analyze is not effective for index '%-.192s', need analyze manually
 '''
 
+["ddl:8270"]
+error = '''
+Invalid engine attribute format: %s
+'''
+
+["ddl:8271"]
+error = '''
+Invalid storage class: %s
+'''
+
 ["ddl:9014"]
 error = '''
 TiFlash backfill index failed: %s

pkg/ddl/create_table.go

@@ -911,6 +911,8 @@ func handleTableOptions(options []*ast.TableOption, tbInfo *model.TableInfo) err
 
 			tbInfo.TTLInfo = ttlInfo
 			ttlOptionsHandled = true
+		case ast.TableOptionEngineAttribute:
+			return errors.Trace(dbterror.ErrUnsupportedEngineAttribute)
 		}
 	}
 	shardingBits := shardingBits(tbInfo)

pkg/ddl/executor.go

@@ -1874,6 +1874,8 @@ func (e *executor) AlterTable(ctx context.Context, sctx sessionctx.Context, stmt
 						Name: ast.NewCIStr(opt.StrValue),
 					}
 				case ast.TableOptionEngine:
+				case ast.TableOptionEngineAttribute:
+					err = dbterror.ErrUnsupportedEngineAttribute
 				case ast.TableOptionRowFormat:
 				case ast.TableOptionTTL, ast.TableOptionTTLEnable, ast.TableOptionTTLJobInterval:
 					var ttlInfo *model.TTLInfo

pkg/errno/errcode.go

@@ -941,6 +941,7 @@ const (
 	ErrConstraintNotFound                                    = 3940
 	ErUserAccessDeniedForUserAccountBlockedByPasswordLock    = 3955
 	ErrDependentByCheckConstraint                            = 3959
+	ErrEngineAttributeNotSupported                           = 3981
 	ErrJSONInBooleanContext                                  = 3986
 	ErrTableWithoutPrimaryKey                                = 3750
 	// MariaDB errors.
@@ -1157,6 +1158,10 @@ const (
 	ErrResourceGroupInvalidBackgroundTaskName = 8255
 	ErrResourceGroupInvalidForRole            = 8257
 
+	// Reserved for future use.
+	ErrEngineAttributeInvalidFormat = 8270
+	ErrStorageClassInvalidSpec      = 8271
+
 	// TiKV/PD/TiFlash errors.
 	ErrPDServerTimeout           = 9001
 	ErrTiKVServerTimeout         = 9002

pkg/errno/errname.go

@@ -943,6 +943,7 @@ var MySQLErrName = map[uint16]*mysql.ErrMessage{
 	ErrTableWithoutPrimaryKey:                                mysql.Message("Unable to create or change a table without a primary key, when the system variable 'sql_require_primary_key' is set. Add a primary key to the table or unset this variable to avoid this message. Note that tables without a primary key can cause performance problems in row-based replication, so please consult your DBA before changing this setting.", nil),
 	ErrConstraintNotFound:                                    mysql.Message("Constraint '%s' does not exist.", nil),
 	ErrDependentByCheckConstraint:                            mysql.Message("Check constraint '%s' uses column '%s', hence column cannot be dropped or renamed.", nil),
+	ErrEngineAttributeNotSupported:                           mysql.Message("Storage engine does not support ENGINE_ATTRIBUTE.", nil),
 	ErrJSONInBooleanContext:                                  mysql.Message("Evaluating a JSON value in SQL boolean context does an implicit comparison against JSON integer 0; if this is not what you want, consider converting JSON to a SQL numeric type with JSON_VALUE RETURNING", nil),
 	// MariaDB errors.
 	ErrOnlyOneDefaultPartionAllowed:         mysql.Message("Only one DEFAULT partition allowed", nil),
@@ -1155,6 +1156,9 @@ var MySQLErrName = map[uint16]*mysql.ErrMessage{
 	ErrResourceGroupQueryRunawayQuarantine:    mysql.Message("Quarantined and interrupted because of being in runaway watch list", nil),
 	ErrResourceGroupInvalidBackgroundTaskName: mysql.Message("Unknown background task name '%-.192s'", nil),
 
+	ErrEngineAttributeInvalidFormat: mysql.Message("Invalid engine attribute format: %s", nil),
+	ErrStorageClassInvalidSpec:      mysql.Message("Invalid storage class: %s", nil),
+
 	// TiKV/PD errors.
 	ErrPDServerTimeout:           mysql.Message("PD server timeout: %s", nil),
 	ErrTiKVServerTimeout:         mysql.Message("TiKV server timeout", nil),

pkg/meta/model/bdr.go

@@ -102,6 +102,7 @@ var BDRActionMap = map[DDLBDRType][]ActionType{
 		ActionAlterTablePartitioning,
 		ActionRemovePartitioning,
 		ActionAddVectorIndex,
+		ActionModifyEngineAttribute,
 	},
 	UnmanagementDDL: {
 		ActionCreatePlacementPolicy,

pkg/meta/model/job.go

@@ -112,6 +112,7 @@ const (
 	ActionAlterTablePartitioning ActionType = 71
 	ActionRemovePartitioning     ActionType = 72
 	ActionAddVectorIndex         ActionType = 73
+	ActionModifyEngineAttribute  ActionType = 74
 )
 
 // ActionMap is the map of DDL ActionType to string.
@@ -184,6 +185,7 @@ var ActionMap = map[ActionType]string{
 	ActionAlterTablePartitioning:        "alter table partition by",
 	ActionRemovePartitioning:            "alter table remove partitioning",
 	ActionAddVectorIndex:                "add vector index",
+	ActionModifyEngineAttribute:         "modify engine attribute",
 
 	// `ActionAlterTableAlterPartition` is removed and will never be used.
 	// Just left a tombstone here for compatibility.

pkg/parser/ast/ddl.go

@@ -2541,6 +2541,7 @@ const (
 	TableOptionTTL
 	TableOptionTTLEnable
 	TableOptionTTLJobInterval
+	TableOptionEngineAttribute
 	TableOptionPlacementPolicy = TableOptionType(PlacementOptionPolicy)
 	TableOptionStatsBuckets    = TableOptionType(StatsOptionBuckets)
 	TableOptionStatsTopN       = TableOptionType(StatsOptionTopN)

pkg/parser/keywords_test.go

@@ -36,7 +36,7 @@ func TestKeywords(t *testing.T) {
 }
 
 func TestKeywordsLength(t *testing.T) {
-	require.Equal(t, 654, len(parser.Keywords))
+	require.Equal(t, 655, len(parser.Keywords))
 
 	reservedNr := 0
 	for _, kw := range parser.Keywords {

pkg/parser/misc.go

@@ -365,6 +365,7 @@ var tokenMap = map[string]int{
 	"ENFORCED":                 enforced,
 	"ENGINE":                   engine,
 	"ENGINES":                  engines,
+	"ENGINE_ATTRIBUTE":         engine_attribute,
 	"ENUM":                     enum,
 	"ERROR":                    errorKwd,
 	"ERRORS":                   identSQLErrors,