Correctly calculate wetted perimeter when components have depletable flags #2067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Update the method
Block.getWettedPerimeter()
to correctly find components whether or not they haveFlags.DEPLETABLE
.This is kind of an ugly implementation, but that's a result of using
Flags
to mark components as depletable. TheFlags
system probably shouldn't be used for this purpose; it would be preferable if there was adepletable
property of components separate from the flags system (e.g., likename
orspatialGrid
)Why is the change being made?
Sometimes the same components that define the wetted perimeter of a block will also be marked as depletable. We want to be able to run TH calculations that need to calculate the wetted perimeter at the same time as the depletion calculations..
Checklist
doc
folder.pyproject.toml
.