Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Database3 from the namespace #2052

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Removing Database3 from the namespace #2052

merged 1 commit into from
Jan 13, 2025

Conversation

john-science
Copy link
Member

@john-science john-science commented Jan 13, 2025 •
edited
Loading

What is the change?

Removing Database3 from the API, use Database.

Why is the change being made?

The name Database3 has always been confusing, and it has been a long process to remove it. This moment marks the first time that I have been able to say that no one downstream uses the API endpoint Database3.

close #1673

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority labels Jan 13, 2025
opotowsky
opotowsky approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@opotowsky opotowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

Finally!

@john-science john-science merged commit 1618c29 into main Jan 13, 2025
22 checks passed
@john-science john-science deleted the rm_db3 branch January 13, 2025 22:35
drewj-tp added a commit that referenced this pull request Jan 14, 2025
@drewj-tp
Merge remote-tracking branch 'origin/main' into drewj/composite-iter/…
61189f1 
…1915

* origin/main:
  Putting Python exe file path in Case logs (#2053)
  Removing Database3 from the namespace (#2052)
  Cleaning up some casual docstrings (#2048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the name Database3 to Database
2 participants
@john-science @opotowsky