Fix #12555: Error "grant not found for key id"

[dshkyra]

When a KMS grant was not found, terraform apply failed during
refreshing state with an error "grant not found for key id".

Now, when a KMS grant is not found, it is treated as revoked and
terraform shows the change in the plan and recreates it during apply.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12555

Release note for CHANGELOG:

resource/aws_kms_grant: Fix error "grant not found for key id" during terraform apply during refreshing state

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSKmsGrant'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsGrant -timeout 120m
...
--- PASS: TestAccAWSKmsGrant_ARN (38.75s)
--- PASS: TestAccAWSKmsGrant_Basic (39.18s)
--- PASS: TestAccAWSKmsGrant_withRetiringPrincipal (39.32s)
--- PASS: TestAccAWSKmsGrant_bare (40.15s)
--- PASS: TestAccAWSKmsGrant_withConstraints (46.74s)
--- PASS: TestAccAWSKmsGrant_disappears (219.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	220.491s

[bflad]

☝️ Fixed simple merge conflict since we just merged another PR affecting that file.

[bflad]

Hi @dshkyra 👋 This looks really good, just needs updates for the testing due to #11991 being merged. Once those are in, we'll merge this in. Thanks!

[dshkyra]

@bflad thanks for your comments. I've updated the PR and re-run integration tests ✅.

[bflad]

Looks good, thanks @dshkyra for the update and of course the fix! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSKmsGrant_Basic (36.00s)
--- PASS: TestAccAWSKmsGrant_ARN (43.76s)
--- PASS: TestAccAWSKmsGrant_bare (44.22s)
--- PASS: TestAccAWSKmsGrant_withRetiringPrincipal (44.30s)
--- PASS: TestAccAWSKmsGrant_withConstraints (50.11s)
--- PASS: TestAccAWSKmsGrant_disappears (233.92s)

[ghost]

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!