Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Kms grant import #11991

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11976

Release note for CHANGELOG:

resource_aws_kms_grant: add import support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSKmsGrant_'
--- PASS: TestAccAWSKmsGrant_ARN (99.06s)
--- PASS: TestAccAWSKmsGrant_bare (90.76s)
--- PASS: TestAccAWSKmsGrant_withRetiringPrincipal (98.01s)
--- PASS: TestAccAWSKmsGrant_withConstraints (138.86s)
--- PASS: TestAccAWSKmsGrant_Basic (91.78s)

@DrFaust92 DrFaust92 requested a review from a team February 11, 2020 12:53
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 11, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 24, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, @DrFaust92 -- one minor documentation update and this should be good to go. 👍

@bflad bflad self-assigned this Mar 24, 2020
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 24, 2020
@DrFaust92 DrFaust92 requested a review from bflad March 24, 2020 19:57
@bflad bflad added this to the v2.56.0 milestone Mar 30, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSKmsGrant_ARN (35.93s)
--- PASS: TestAccAWSKmsGrant_withRetiringPrincipal (35.99s)
--- PASS: TestAccAWSKmsGrant_Basic (44.34s)
--- PASS: TestAccAWSKmsGrant_bare (44.42s)
--- PASS: TestAccAWSKmsGrant_withConstraints (51.33s)

@bflad bflad merged commit 1dad917 into hashicorp:master Mar 30, 2020
bflad added a commit that referenced this pull request Mar 30, 2020
@ghost
Copy link

ghost commented Apr 3, 2020

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the kms-grant-import branch April 7, 2020 14:55
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

1 similar comment
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kms Issues and PRs that pertain to the kms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource aws_kms_grant doesn't support import
3 participants