terraform_required_providers: fix regression with configuration_aliases
#1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
approved these changes
Jul 29, 2022
| // @see https://www.terraform.io/language/modules/develop/providers#provider-aliases-within-modules | ||
| name: cty.DynamicVal, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
Interesting. FWIW, Terraform core uses hcl.ExprMap, so it's probably best to do so.
https://github.com/hashicorp/terraform/blob/v1.2.6/internal/configs/provider_requirements.go#L78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression, described in #1450. When evaluating an entry in
required_providers, this adds a variable (dynamic value) with the provider's name, allowing the evaluation ofconfiguration_aliases. This evaluation is looser than Terraform would perform, e.g.,configuration_aliases = [aws.foo.bar]would presumably be considered valid. References to other providers should still fail.Closes #1450