feat: update module inputs for da solution #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
ocofaigh
requested changes
Apr 14, 2024
solutions/instances/variables.tf
Outdated
| @@ -202,6 +202,18 @@ variable "scc_instance_tags" { | |||
| default = [] | |||
| } | |||
|
|
|||
| variable "attach_wp_to_scc_instance" { | |||
There was a problem hiding this comment.
don't expose this - if provision_scc_workload_protection is true then the DA code should automatically set attach it to the SCC instance
tests/pr_test.go
Outdated
| @@ -79,6 +79,8 @@ func TestInstancesInSchematics(t *testing.T) { | |||
| {Name: "scc_cos_bucket_access_tags", Value: permanentResources["accessTags"], DataType: "list(string)"}, | |||
| {Name: "scc_wp_access_tags", Value: permanentResources["accessTags"], DataType: "list(string)"}, | |||
| {Name: "cos_instance_access_tags", Value: permanentResources["accessTags"], DataType: "list(string)"}, | |||
| {Name: "attach_wp_to_scc_instance", Value: true, DataType: "bool"}, | |||
There was a problem hiding this comment.
remove this since we will remove the attach_wp_to_scc_instance variable
|
/run pipeline |
added 2 commits
April 14, 2024 23:41
|
/run pipeline |
ocofaigh
reviewed
Apr 15, 2024
tests/pr_test.go
Outdated
| @@ -79,6 +79,8 @@ func TestInstancesInSchematics(t *testing.T) { | |||
| {Name: "scc_cos_bucket_access_tags", Value: permanentResources["accessTags"], DataType: "list(string)"}, | |||
| {Name: "scc_wp_access_tags", Value: permanentResources["accessTags"], DataType: "list(string)"}, | |||
| {Name: "cos_instance_access_tags", Value: permanentResources["accessTags"], DataType: "list(string)"}, | |||
| {Name: "provision_scc_workload_protection", Value: true, DataType: "bool"}, | |||
| {Name: "skip_scc_wp_auth_policy", Value: false, DataType: "bool"}, | |||
There was a problem hiding this comment.
these are the default values so no need to explicitly specify here
ocofaigh
reviewed
Apr 15, 2024
solutions/instances/variables.tf
Outdated
| variable "skip_scc_wp_auth_policy" { | ||
| type = bool | ||
| default = false | ||
| description = "Set to true to skip the creation of an IAM authorization policy that permits the SCC instance created by this solution read access to the workload protection instance. Only used if `attach_wp_to_scc_instance` is set to true." |
There was a problem hiding this comment.
remove attach_wp_to_scc_instance from the description - its no an exposed variable in this DA. I guess it should be replaced by provision_scc_workload_protection
added 2 commits
April 15, 2024 18:32
|
/run pipeline |
ocofaigh
approved these changes
Apr 16, 2024
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update module inputs in da solution to attach workload protection instance.
#23
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Update module inputs in da solution to attach workload protection instance.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers