-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for at management events #847
Conversation
/run pipeline |
@ocofaigh we have not bumped the version of the ibm provider in the examples and patterns. should I do that? |
@kierramarie yes please update the required provider version - there are multiple places you will need to update it throughout the code, so do a find and replace everywhere |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kierramarie your missing some provider version updates. For example, each of the patterns have a modules folder - you going to need to update those too. Suggest to do a find for the text required_providers
and review every file
/run pipeline |
Will merge #848 first and then rebase this and merge |
/run pipeline |
2 similar comments
/run pipeline |
/run pipeline |
Pipeline is hitting a few intermittent issue, so going to retry.. |
/run pipeline |
1 similar comment
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
1 similar comment
/run pipeline |
/run pipeline |
@kierramarie can you resolve conflicts and lets see how tests get on |
/run pipeline |
Interesting that we do not use this feature in our patterns at all, which is why the tests are successful even though this new parameter is not optional. Just mentioning it for history. We do not use this |
🎉 This issue has been resolved in version 5.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Provider has added support for management_events for atracker. Support for this has been added to cos.tf
Issue: #820
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers