Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for at management events #847

Merged
merged 11 commits into from
Aug 27, 2024
Merged

feat: add support for at management events #847

merged 11 commits into from
Aug 27, 2024

Conversation

kierramarie
Copy link
Contributor

Description

Provider has added support for management_events for atracker. Support for this has been added to cos.tf

Issue: #820

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie
Copy link
Contributor Author

/run pipeline

@kierramarie
Copy link
Contributor Author

@ocofaigh we have not bumped the version of the ibm provider in the examples and patterns. should I do that?

@ocofaigh
Copy link
Member

@kierramarie yes please update the required provider version - there are multiple places you will need to update it throughout the code, so do a find and replace everywhere

@kierramarie
Copy link
Contributor Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kierramarie your missing some provider version updates. For example, each of the patterns have a modules folder - you going to need to update those too. Suggest to do a find for the text required_providers and review every file

@kierramarie
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Member

Will merge #848 first and then rebase this and merge

ocofaigh
ocofaigh previously approved these changes Jul 30, 2024
@ocofaigh
Copy link
Member

/run pipeline

2 similar comments
@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh
Copy link
Member

Pipeline is hitting a few intermittent issue, so going to retry..

@ocofaigh
Copy link
Member

/run pipeline

1 similar comment
@ocofaigh
Copy link
Member

ocofaigh commented Aug 2, 2024

/run pipeline

@kierramarie
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh
Copy link
Member

/run pipeline

1 similar comment
@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh
Copy link
Member

@kierramarie can you resolve conflicts and lets see how tests get on

@kierramarie
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor

Interesting that we do not use this feature in our patterns at all, which is why the tests are successful even though this new parameter is not optional.

Just mentioning it for history. We do not use this cos.activity_tracker block from any of our solutions.

@ocofaigh ocofaigh merged commit 835d676 into main Aug 27, 2024
2 checks passed
@ocofaigh ocofaigh deleted the ks-cos-me branch August 27, 2024 09:04
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This issue has been resolved in version 5.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants