Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kube to kms auth policy creation #685

Merged
merged 3 commits into from
Jan 30, 2024
Merged

fix: kube to kms auth policy creation #685

merged 3 commits into from
Jan 30, 2024

Conversation

Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Jan 23, 2024

Description

Addded kube to KMS auth policy creation.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Ak-sky Ak-sky requested review from Aashiq-J and ocofaigh January 23, 2024 11:02
@Ak-sky
Copy link
Member Author

Ak-sky commented Jan 23, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jan 23, 2024

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jan 23, 2024

Test is failing with this -

Error: UpgradeQuickStartPattern 2024-01-23T11:34:36Z command.go:185: │ Error: [ERROR] Error Deleting resource group: Resource groups with active or pending reclamation instances can't be deleted. Use the CLI commands "ibmcloud resource service-instances --type all" and "ibmcloud resource reclamations" to check for remaining instances, then delete the instances and try again. with response code {

@Ak-sky
Copy link
Member Author

Ak-sky commented Jan 23, 2024

/run pipeline

@ocofaigh
Copy link
Member

There is a support case open to debug the issue our pipeline is hitting. Seems to be related to backend volume cleanup not being processed by resource controller

@Ak-sky
Copy link
Member Author

Ak-sky commented Jan 24, 2024

/run pipeline

@ocofaigh
Copy link
Member

@Ak-sky hold off on running the pipeline - I bumped the severity of the support case

@ocofaigh
Copy link
Member

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Jan 29, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 03cb99c into main Jan 30, 2024
2 checks passed
@ocofaigh ocofaigh deleted the s2s-auth branch January 30, 2024 09:25
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 5.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants