Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some variables are not used (disk_size, disk_type, pricing_plan, replication_type) #2

Closed
tpoindessous opened this issue Dec 30, 2017 · 2 comments
Closed

some variables are not used (disk_size, disk_type, pricing_plan, replication_type) #2

tpoindessous opened this issue Dec 30, 2017 · 2 comments

Comments

@tpoindessous
Copy link
Contributor

Hi

thank you for your module. I noticed that some variables are not used :

  • disk_size
  • disk_type
  • pricing_plan
  • replication_type

I really care about disk_size but other people may have the need of others.

As a new year resolution, I will try to send you a pull request for these, but also for adding support for failover instance.

Thanks !
@tpoindessous
Copy link
Contributor Author

Corrected in PR #4

Thanks !

@danisla
Copy link
Contributor

danisla commented Jan 3, 2018

Fixed with #4

@danisla danisla closed this as completed Jan 3, 2018
rebelthor pushed a commit to rebelthor/terraform-google-sql-db that referenced this issue Jul 13, 2020
Backup location on postgresql terraform-google-modules#2
2345200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danisla @tpoindessous