Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add Terraform 0.13 constraint and module attribution #38

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

cloud-foundation-bot
Copy link
Collaborator

This PR was auto generated, please review for accuracy before merging

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante morgante merged commit c423601 into master Mar 15, 2021
@morgante morgante deleted the bot-add-module-attribution branch March 15, 2021 18:34
@release-please release-please bot mentioned this pull request Mar 15, 2021
@tpdownes
Copy link
Member

tpdownes commented May 7, 2021

@morgante I'm curious if the 0.13.0 constraint is being imposed solely because of the required_providers blocks? If so, they announced that feature in 0.13.0 but backported to 0.12.20:

https://github.com/hashicorp/terraform/blob/v0.12/CHANGELOG.md#01220-january-22-2020

Google Cloud Shell version of Terraform remains pretty low and some users choose to move slowly (for better/worse).

If the GitHub tags are to be believed, provider_meta appears to be truly 0.13.0+.

@bharathkkb
Copy link
Member

@tpdownes this constraint was primarily to support provider_meta which would otherwise cause issues like terraform-google-modules/terraform-google-network#235

@tpdownes
Copy link
Member

tpdownes commented May 7, 2021

Yeah, I see that. It's unfortunate terraform can't silently fail on it. But, I only really see one new feature between 3.0.1 and 4.0.0 so it doesn't much matter. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants