use for_each instead of count to create resource #15
Conversation
This prevents unnecessary recreation of resources when content/order of the names list changes. Addresses issue mentioned in: https://github.com/terraform-google-modules/cloud-foundation-fabric/tree/73b7613cc062491305ebfabf8a8b1db0c53fc55b/foundations#things-to-be-aware-of WARNING: this is a breaking change as the terraform state created before this change will be incompatible with state expected after the change. This can be fixed with `terraform state mv`.
adrian-gierakowski
requested review from
aaron-lane,
averbuks,
ludoo and
morgante
as code owners
|
this is similar to terraform-google-modules/terraform-google-folders#21 |
|
Adrian, can you make sure tests pass? I know it's kind of a bother, but it's pretty important especially when doing breaking changes and setting a new baseline. |
|
Yes, sure. Will try to fix it later today. |
|
@ludoo so the tests pass, but I had to patch the gcr/images/cloud-foundation-cicd/cft/kitchen-terraform image locally since the latest available version (2.4.0) comes with terraform 0.12.3 which has no support for |
|
@adrian-gierakowski We should switch to using the devtools image, which has support for Terraform 0.12.6. Ex. https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/Makefile#L22 |
|
not sure why it's failing this time, maybe someone with access to cloudbuild logs can pick this up |
The Cloud Build trigger is looking for a missing cloudbuild.yaml file. @averbuks can you check it out? |
|
@ludoo @adrian-gierakowski it's failing because that repo is still using "old way" of testing, I will take it #7 |
|
@adrian-gierakowski looks really good, could you pls add that change as unreleased to the CHANGELOG |
I hope you don't mind I did it myself |
|
UP, can you merge this PR ? |
This prevents unnecessary recreation of resources when content/order of the
names list changes.
Addresses issue mentioned in: https://github.com/terraform-google-modules/cloud-foundation-fabric/tree/73b7613cc062491305ebfabf8a8b1db0c53fc55b/foundations#things-to-be-aware-of
WARNING: this is a breaking change as the terraform state created before this
change will be incompatible with state expected after the change. This can
be fixed with
terraform state mv.