Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add connection metadata #222

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: add connection metadata #222

wants to merge 8 commits into from

Conversation

ktinubu
Copy link
Contributor

@ktinubu ktinubu commented Jan 28, 2025

Add connection metadata:

  • bigquery module output table_ids[0] -> bigquery_subscription table (uses first table_id)
  • Cloud storage module output name -> cloud_storage_subscription bucket
  • kms module output keys(keys)[0] -> topic_kms_key_name (expects keys map to contain a single key)

@ktinubu ktinubu requested a review from q2w January 28, 2025 19:57
@ktinubu ktinubu self-assigned this Jan 28, 2025
@ktinubu ktinubu requested review from imrannayer and a team as code owners January 28, 2025 19:57
@ktinubu ktinubu assigned q2w and unassigned ktinubu Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q2w q2w Awaiting requested review from q2w

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@q2w q2w

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktinubu @q2w