Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: generate display metadata #219

Merged
merged 4 commits into from
Jan 23, 2025
Merged

chore: generate display metadata #219

merged 4 commits into from
Jan 23, 2025

Conversation

ktinubu
Copy link
Contributor

@ktinubu ktinubu commented Jan 23, 2025

Regenerate blueprint metadata with metadata.display.yaml

via:

cft blueprint metadata -d -f

Lint now passes with metada enabled:

make docker_run
export ENABLE_BPMETADATA=1
/usr/local/bin/test_lint.sh

@ktinubu ktinubu requested a review from apeabody January 23, 2025 15:13
@ktinubu ktinubu self-assigned this Jan 23, 2025
@ktinubu ktinubu requested review from imrannayer and a team as code owners January 23, 2025 15:13
@ktinubu ktinubu changed the title Chore/generate display metadata chore/generate display metadata Jan 23, 2025
@ktinubu ktinubu changed the title chore/generate display metadata chore: generate display metadata Jan 23, 2025
apeabody
apeabody approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktinubu!

@apeabody apeabody merged commit 7259273 into terraform-google-modules:main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

Assignees

@ktinubu ktinubu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktinubu @apeabody