Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove count in favor of sets #954

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hareware-labs
Copy link

  • In this module, as it stands, if additional vpc subnets are added, google_compute_subnetwork_iam_member resources are deleted and recreated.
  • Switching to lists preserves resources during applies where additional subnets are added.
  • This change removes count in favor of the for_each / toset construct so that order is maintained during applies.

@hareware-labs hareware-labs requested a review from a team as a code owner November 19, 2024 20:47
Copy link

google-cla bot commented Nov 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hareware-labs hareware-labs marked this pull request as draft November 19, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant