1.0 - G Suite Refactor

[morgante]

This PR is to track the final merge of the G Suite refactor and release.

Fixes/changes should be done as PRs against 1.0-rc1.

[morgante]

It looks like attempting to merge in master somehow broke this. The issue is somewhere in here: https://github.com/terraform-google-modules/terraform-google-project-factory/pull/94/files/bb2b84289d32555a2e1976a89f4ae66dc38da526..4ff2d26bc1a6c4ac47a4e3c4326421bbba217b9b

[morgante]

Sadly it looks like this is still breaking CI:

       Error: Error running plan: 5 error(s) occurred:
       
       * module.project-factory.module.project-factory.google_service_account_iam_member.service_account_grant_to_group: google_service_account_iam_member.service_account_grant_to_group: value of 'count' cannot be computed
       * google_service_account_iam_member.additive_service_account_grant_to_group: google_service_account_iam_member.additive_service_account_grant_to_group: value of 'count' cannot be computed
       * module.project-factory.module.project-factory.google_compute_subnetwork_iam_member.group_role_to_vpc_subnets: google_compute_subnetwork_iam_member.group_role_to_vpc_subnets: value of 'count' cannot be computed
       * module.project-factory.module.project-factory.google_storage_bucket_iam_member.group_storage_admin_on_project_bucket: google_storage_bucket_iam_member.group_storage_admin_on_project_bucket: value of 'count' cannot be computed
       * module.project-factory.module.project-factory.google_project_iam_member.gsuite_group_role: google_project_iam_member.gsuite_group_role: value of 'count' cannot be computed

[morgante]

It looks like we still don't have the group logic quite right. We need parity with the current project factory.

To be specific, if I am using the non-G Suite project factory, I have two options:

1. Pass in a group_name and it will be granted all the appropriate roles (ex.

   terraform-google-project-factory/modules/core_project_factory/main.tf

   Line 203 in ab49539

   resource "google_service_account_iam_member" "service_account_grant_to_group" {

   )
2. Don't pass in a group_name and no roles will be added

For the G Suite version, there are 4 options:

1. Pass in a group_name and create_group = false => grant the roles to the group
2. Pass in a group_name and create_group = true => create the given group name and grant it the required roles
3. Don't pass in a group_name and create_group = true => creates a group named project_name-editors and grants it the required roles.
4. Don't pass in a group_name and create_group = false -> no group roles granted