Implement Billing Account Role #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added more output so that the user knows that execution is happening
morgante
approved these changes
Oct 19, 2018
adrienthebo
approved these changes
Oct 19, 2018
adrienthebo
suggested changes
Oct 19, 2018
helpers/setup-sa.sh
Outdated
| echo "Could not set roles/billing.user on service account $SERVICE_ACCOUNT.\ | ||
| Please perform this manually." | ||
| fi | ||
| rm -f policy-tmp-$$.json |
There was a problem hiding this comment.
The extension of this file is incorrect, it should be .yml but is .json.
helpers/setup-sa.sh
Outdated
| \ \ role: roles/billing.user" policy-tmp-$$.yml | ||
| gcloud beta billing accounts set-iam-policy $BILLING_ACCOUNT policy-tmp-$$.yml | ||
| else | ||
| echo "Could not set roles/billing.user on service account $SERVICE_ACCOUNT.\ |
There was a problem hiding this comment.
Small fixup: since we used a 2 space indent in the previous code, could we switch this block to use 2 spaces as well?
|
Fixed both requested changes @adrienthebo |
adrienthebo
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the helper script the optional creation of the IAM billing role for the service account that is required. Other small changes include: