Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependency for google_project_service #42

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Add explicit dependency for google_project_service #42

merged 1 commit into from
Oct 4, 2018

Conversation

adrienthebo
Copy link
Contributor

The google_project_service.project_services resource depends on
the google_project.project resource, but Terraform was unable to
detect this dependency though the dependencies of the variables in use.
This could lead to Terraform deleting the project and the project
services at the same time.

This commit resolves the issue by adding an explicit dependency from
google_project_service.project_services -> google_project.project.

The `google_project_service.project_services` resource depends on
the `google_project.project` resource, but Terraform was unable to
detect this dependency though the dependencies of the variables in use.
This could lead to Terraform deleting the project and the project
services at the same time.

This commit resolves the issue by adding an explicit dependency from
`google_project_service.project_services` -> `google_project.project`.
@adrienthebo adrienthebo changed the title Add explicit default for google_project_service Add explicit dependency for google_project_service Oct 4, 2018
@adrienthebo adrienthebo requested a review from Jberlinsky October 4, 2018 16:30
Copy link
Contributor

@Jberlinsky Jberlinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and resolves an issue I ran into this morning. 🚢

@morgante morgante merged commit 3ed691e into terraform-google-modules:master Oct 4, 2018
@adrienthebo adrienthebo deleted the project_services_deps branch October 4, 2018 18:12
adrienthebo added a commit that referenced this pull request Oct 8, 2018
The `google_project_service.project_services` resource depends on
the `google_project.project` resource, but Terraform was unable to
detect this dependency though the dependencies of the variables in use.
This could lead to Terraform deleting the project and the project
services at the same time.

This commit resolves the issue by adding an explicit dependency from
`google_project_service.project_services` -> `google_project.project`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants