Gsuite group name output in gsuite modules #288

ideasculptor · 2019-10-17T18:37:21Z

Fixes #287

of project modules that all use the same group, with only one creating it.

morgante

Just one nit.

morgante · 2019-10-17T18:38:42Z

modules/gsuite_enabled/outputs.tf

@@ -36,6 +36,11 @@ output "group_email" {
  description = "The email of the created GSuite group with group_name"
 }

+output "group_name" {
+  value       = module.gsuite_group.name
+  description = "The email name of the created GSuite group with group_name"


Suggested change

description = "The email name of the created GSuite group with group_name"

description = "The email of the G Suite group created with group_name"

I didn't quite use your suggestion, as the GSuite spelling wasn't consistent with the prior output, and your description was maybe confusing about the difference between group_email and group_name, so I went with "The group_name of the GSuite group"

We should still fix it to be "G Suite" as that is the official name.

If this output is "my-team" (not [email protected]) then the proposed description makes sense.

Yes, that's correct. group_email is the full address, group_name is just the username portion of the address, but I wanted to avoid the word username. I just pushed an update with the spelling correction, too.

ideasculptor · 2019-10-18T22:10:44Z

is the failing trigger just that it isn't approved by a reviewer yet, or is something else broken? I cant see the cloud-build details to confirm what is breaking. All of the commits that followed the first one have a failed trigger, but they are only changes to variable and output descriptions that appear syntactically correct - perhaps there's a test that is looking for specific output strings?

Is there a way to run tests locally, so I can update them if needed?

morgante · 2019-10-18T22:13:14Z

It's actually the linting tests that are failing.

You can run the tests locally using Docker, as documented here.

morgante · 2019-10-21T19:40:13Z

@ideasculptor FYI it looks like tests are still failing.

ideasculptor · 2019-10-21T20:43:55Z

Yep, I’ve been busy with other stuff this morning. I’ll get the tests running locally and get it fixed up. I’ve got other PR’s that need completing, too.

…m-google-project-factory into gsuite_group_name_output

ideasculptor · 2019-10-25T21:39:57Z

It looks like all of the current PR's are now failing, which makes me suspect a problem that is independent of the PRs. I've updated the code to include updated docs and to ensure it passes the lint test locally, but it is still failing here. Or, at least, something is failing, but I don't have visibility into what.

I tried running the integration tests locally, but that is failing with a permissions problem that doesn't make sense to me, since I do have ProjectCreator role in the folder it creates, so I'm guessing that is the breakage referenced above. As such, it doesn't seem valuable to try to keep digging into it locally, since I don't think the failure is attributable to my changes.

ideasculptor · 2019-10-25T21:56:56Z

Incidentally, is there a command I can use to perform state cleanup in the tests? It is now trying to create a project that it already created and then deleted when there was a failure. I need to taint the resource that generates the suffix on the project id, but I can't figure out an easy way to do so without disassembling all of the scripts and manually performing all the steps needed to be able run terraform taint.

morgante · 2019-10-25T21:59:44Z

@ideasculptor You can run docker_test_cleanup: https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/Makefile#L49

I'll try to dig into why things are failing shortly.

ideasculptor · 2019-10-25T22:15:50Z

It is dying with the following output. The log files mentioned don't contain any interesting content.

       module.project-factory.module.project-factory.google_project.main: Still creating... [1m40s elapsed]
       
       Error: Error deleting default network in project pf-ci-test-minimal-ffc7ac-9c66: Error waiting for Deleting Network: The network resource 'projects/pf-ci-test-minimal-ffc7ac-9c66/global/networks/default' is already being used by 'projects/pf-ci-test-minimal-ffc7ac-9c66/global/firewalls/default-allow-ssh'
       
       
         on ../../../modules/core_project_factory/main.tf line 126, in resource "google_project" "main":
        126: resource "google_project" "main" {
       
       
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 1 actions failed.
>>>>>>     Converge failed on instance <minimal-local>.  Please see .kitchen/logs/minimal-local.log for more details
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration

That kind of feels like an error in the underlying gcloud api or the terraform provider, since it seems to be objecting to creating a google_project resource with auto_create_network = false

morgante · 2019-10-25T22:29:22Z

@ideasculptor Can you try pinning the provider version to 2.18.1, as per https://github.com/terraform-providers/terraform-provider-google/blob/master/CHANGELOG.md#2181-october-25-2019

ideasculptor · 2019-10-26T01:17:28Z

Forcing it to 2.18.1 does cause the tests to pass locally, but short of committing my changes which set the version explicitly to ~> 2.18.1, I'm not sure how to get the CI pipeline here to grab the latest version of the provider. I'd have thought it would do that automatically, by virtue of its availability, but I guess it just uses the latest version that it has in cache which satisfies the ~> 2.1 requirement that was the original value.

…ete error

ideasculptor · 2019-10-29T00:46:39Z

this was approved but not merged. Any chance it can be merged? I'd love to get away from my fork and back on the mainline.

morgante · 2019-10-29T02:30:06Z

@ideasculptor Thanks, I was just waiting for CI to verify before merging.

Sam Gendler added 2 commits October 17, 2019 10:34

Add group name output to gsuite_group module

c511e9a

added group name to outputs of module, in order to allow chaining

7c84dd8

of project modules that all use the same group, with only one creating it.

ideasculptor requested review from aaron-lane, adrienthebo and morgante as code owners October 17, 2019 18:37

morgante suggested changes Oct 17, 2019

View reviewed changes

Sam Gendler added 3 commits October 17, 2019 12:17

Updated comment a la code review

a8e1b7c

correcting GSuite to 'G Suite'

dc8f8d3

de-GSuited the codebase

bbb4f81

Merge branch 'master' into gsuite_group_name_output

31d6cb0

Sam Gendler added 2 commits October 25, 2019 14:10

Merge branch 'master' of github.com:terraform-google-modules/terrafor…

f970569

…m-google-project-factory into gsuite_group_name_output

updated docs and passes lint test

efd7e8e

Sam Gendler and others added 3 commits October 25, 2019 18:17

Update minimum version for provider to workaround default network del…

694cb50

…ete error

add the ~> qualifier to versions

4346867

Merge branch 'master' into gsuite_group_name_output

211e71d

morgante approved these changes Oct 28, 2019

View reviewed changes

morgante merged commit 4870a65 into terraform-google-modules:master Oct 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gsuite group name output in gsuite modules #288

Gsuite group name output in gsuite modules #288

ideasculptor commented Oct 17, 2019 •

edited by morgante

Loading

morgante left a comment

morgante Oct 17, 2019

ideasculptor Oct 17, 2019

morgante Oct 17, 2019

ideasculptor Oct 18, 2019

ideasculptor commented Oct 18, 2019

morgante commented Oct 18, 2019

morgante commented Oct 21, 2019

ideasculptor commented Oct 21, 2019

ideasculptor commented Oct 25, 2019

ideasculptor commented Oct 25, 2019

morgante commented Oct 25, 2019 •

edited

Loading

ideasculptor commented Oct 25, 2019 •

edited

Loading

morgante commented Oct 25, 2019

ideasculptor commented Oct 26, 2019

ideasculptor commented Oct 29, 2019

morgante commented Oct 29, 2019

	description = "The email name of the created GSuite group with group_name"
	description = "The email of the G Suite group created with group_name"

Gsuite group name output in gsuite modules #288

Gsuite group name output in gsuite modules #288

Conversation

ideasculptor commented Oct 17, 2019 • edited by morgante Loading

morgante left a comment

Choose a reason for hiding this comment

morgante Oct 17, 2019

Choose a reason for hiding this comment

ideasculptor Oct 17, 2019

Choose a reason for hiding this comment

morgante Oct 17, 2019

Choose a reason for hiding this comment

ideasculptor Oct 18, 2019

Choose a reason for hiding this comment

ideasculptor commented Oct 18, 2019

morgante commented Oct 18, 2019

morgante commented Oct 21, 2019

ideasculptor commented Oct 21, 2019

ideasculptor commented Oct 25, 2019

ideasculptor commented Oct 25, 2019

morgante commented Oct 25, 2019 • edited Loading

ideasculptor commented Oct 25, 2019 • edited Loading

morgante commented Oct 25, 2019

ideasculptor commented Oct 26, 2019

ideasculptor commented Oct 29, 2019

morgante commented Oct 29, 2019

ideasculptor commented Oct 17, 2019 •

edited by morgante

Loading

morgante commented Oct 25, 2019 •

edited

Loading

ideasculptor commented Oct 25, 2019 •

edited

Loading