Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for issuue #47 #257

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Fixes for issuue #47 #257

merged 1 commit into from
Aug 14, 2019

Conversation

ingwarr
Copy link
Contributor

@ingwarr ingwarr commented Aug 12, 2019

Fixes #47

ivankorn
ivankorn reviewed Aug 12, 2019
View reviewed changes
test/make.sh Show resolved Hide resolved
test/make.sh Show resolved Hide resolved
paulpalamarchuk
paulpalamarchuk suggested changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@paulpalamarchuk paulpalamarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update/set variables types

test/fixtures/shared_vpc_no_subnets/main.tf Outdated Show resolved Hide resolved
modules/shared_vpc/variables.tf Show resolved Hide resolved
@ingwarr
Copy link
Contributor Author

ingwarr commented Aug 14, 2019

As I see failing of integration tests not related to my changes:
Error: googleapi: Error 503: The service is currently unavailable., backendError

     on ../../../modules/core_project_factory/main.tf line 126, in resource "google_project" "main":
    126: resource "google_project" "main" {

@nick4fake
Copy link

I was a bit concerned about additional changes, but they were required to set types in the new module.

@nick4fake nick4fake marked this pull request as ready for review August 14, 2019 13:52
@morgante morgante merged commit b84b2aa into terraform-google-modules:master Aug 14, 2019
@ingwarr ingwarr deleted the issue47 branch August 15, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankorn ivankorn ivankorn left review comments

@paulpalamarchuk paulpalamarchuk paulpalamarchuk approved these changes

@morgante morgante morgante approved these changes

@nick4fake nick4fake nick4fake approved these changes

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails with shared VPC being specified using a reference
5 participants
@ingwarr @nick4fake @morgante @paulpalamarchuk @ivankorn