feature #202: authoritative on activate_apis #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-lane
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
aaron-lane
suggested changes
May 27, 2019
|
@alexkonkin It appears that the branch history has been confused; there are commits included which have already been merged to the master branch. Can you rebase this branch against terraform-google-modules:master? |
|
Fixes #202. |
Conflicts: modules/core_project_factory/main.tf
alexkonkin
force-pushed
the
feature/202_activate_apis
branch
from
9e6ebdc to
9aaa38f
Compare
Done. |
alexkonkin
force-pushed
the
feature/202_activate_apis
branch
from
13a7e86 to
1d4e8ca
Compare
aaron-lane
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.