GCP subnet share conditions not working correctly #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rking correctly - added regexp based subnet name validation - added relative region and subnet values extractions from source string
…rking correctly - added second subnet with https://www.googleapis.com/compute/v1 prefix to tests
kopachevsky
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
|
Fixes #152. |
aaron-lane
suggested changes
May 9, 2019
…rking correctly. - fixed subnet region to available
…rking correctly - removed typos - removed meta programming from tests
…rking correctly - fixed local variables initialization from attributes
aaron-lane
suggested changes
May 13, 2019
There was a problem hiding this comment.
@kopachevsky this looks good! Can you please add a CHANGELOG entry and provide a gist which contains the output of a Terraform process when it fails due to an invalid subnet being passed to shared_vpc_subnets?
…rking correctly - temporary commit to check early fail if shared vpc subnet name not valid (HTTPS changed to HTTP) - revert after check
…rking correctly - revert: temporary commit to check early fail if shared vpc subnet name not valid (HTTPS changed to HTTP)
Added CHANGELOG on Concourse build 422, should I copy/paste full terraform output from there for Full test suite? I think it could contain sensitive info |
aaron-lane
approved these changes
May 14, 2019
aaron-lane
added a commit
that referenced
this pull request
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #152
Ready for review