disable_dependent_services argument/variable have been added #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkonkin
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
kopachevsky
reviewed
May 1, 2019
kopachevsky
reviewed
May 1, 2019
kopachevsky
reviewed
May 1, 2019
kopachevsky
previously approved these changes
May 1, 2019
|
Fixes #168 |
aaron-lane
previously requested changes
May 1, 2019
aaron-lane
dismissed
their stale review
I mistakenly confused a different variable.
aaron-lane
suggested changes
May 1, 2019
There was a problem hiding this comment.
Similar to the disable_on_destroy variable, let's add this variable to the root module and the gsuite_enabled submodule, and in both cases, forward the value to the core_project_factory submodule and use it in the google_project_service.project_services resource there.
|
This branch must be rebased against master once #189 is merged. git remote add upstream https://github.com/terraform-google-modules/terraform-google-project-factory.git
git fetch upstream
git checkout master
git merge upstream/master
git checkout bug/project_add_disable_dependent_services
git rebase master
git push --force |
alexkonkin
force-pushed
the
bug/project_add_disable_dependent_services
branch
from
a3cb20d to
603ffdd
Compare
aaron-lane
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument/variable that manages disable_dependent_services has been added