Default Computer Service Account control #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow users to decide to keep, delete, or depriviledge projects default computer service account on creation
mwallman
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
- Fixed trailing whitespace :o
|
looks like a merge from @alexkonkin broke the unit tests, and are blocking my merge. Suggestions on a fix? |
Fixed lint-tests terraform-google-modules#336
Align "=" signs in var definition
Align "=" signs in var definition
Align "=" signs in var definition
…y files; Causes format error - Note: Error 123 is from xargs, signaling a non-zero exit code in ANY of the commands # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # Explicit paths specified without -i or -o; assuming --only paths... # On branch master # Your branch is up-to-date with 'origin/master'. # # Changes to be committed: # modified: modules/core_project_factory/main.tf # modified: modules/core_project_factory/variables.tf #
aaron-lane
suggested changes
May 10, 2019
There was a problem hiding this comment.
@mwallman this looks pretty good. Are you comfortable with adding tests to verify the new behaviour?
|
@aaron-lane I will do that... |
aaron-lane
previously approved these changes
May 16, 2019
morgante
approved these changes
May 16, 2019
| @@ -26,3 +26,7 @@ variable "credentials_path" { | |||
| description = "Path to a service account credentials file with rights to run the Project Factory. If this file is absent Terraform will fall back to Application Default Credentials." | |||
| default = "" | |||
| } | |||
|
|
|||
| variable "default_service_account" { | |||
| description = "Project default service account setting: (delete | depriviledge | keep)" | |||
There was a problem hiding this comment.
Please add a default for this in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default computer service account on creation