Drop unused permissions from preconditions script #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienthebo
force-pushed
the
adrienthebo/maint/preconditions-drop-unused-requirements
branch
2 times, most recently
from
9072f39 to
926009c
Compare
adrienthebo
changed the title
morgante
previously approved these changes
Feb 22, 2019
aaron-lane
previously approved these changes
Feb 22, 2019
The service account running Terraform does not need `roles/iam.serviceAccountAdmin` on the entire organization. This commit updates the README accordingly.
adrienthebo
dismissed stale reviews from aaron-lane and morgante
via
977fc93
adrienthebo
force-pushed
the
adrienthebo/maint/preconditions-drop-unused-requirements
branch
from
2d13558 to
977fc93
Compare
morgante
approved these changes
Feb 22, 2019
aaron-lane
deleted the
adrienthebo/maint/preconditions-drop-unused-requirements
branch
adrienthebo
added a commit
that referenced
this pull request
Feb 22, 2019
aaron-lane
added a commit
that referenced
this pull request
Feb 22, 2019
…nt/update-changelog Add CHANGELOG entries for PR #143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.